Fix TimedPublishSubscriber for doctrine/dbal 4.x#3750
Merged
bobvandevijver merged 12 commits intoJul 20, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates TimedPublishSubscriber to work correctly with doctrine/dbal 4.x by using the supported DBAL APIs and correct parameter binding, and improves diagnostics by logging previously swallowed exceptions.
Changes:
- Replace removed
Connection::executeUpdate()calls withexecuteStatement(). - Fix DBAL 4 named-parameter binding (no colon-prefixed keys) and bind
CarbonwithTypes::DATETIME_MUTABLE. - Add debug-level logging when the subscriber catches an exception.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bobvandevijver
approved these changes
Jul 20, 2026
bobvandevijver
left a comment
bobvandevijver
left a comment
Member
There was a problem hiding this comment.
Actually, lets use the logger trait instead
- Replace removed Connection::executeUpdate() with executeStatement() - Use plain (non colon-prefixed) named parameters as required by DBAL 4 - Pass an explicit Types::DATETIME_MUTABLE type for the bound Carbon/DateTime value - Log caught exceptions at debug level instead of swallowing them silently Fixes bolt#3748
Typing $defaultConnection as the generic 'object' (as returned by ManagerRegistry::getConnection()) hid the executeStatement() method from PHPStan. Narrow it to Doctrine\DBAL\Connection instead, and drop the now-obsolete baseline entry for the old executeUpdate() call.
Matches CI's ClassPropertyAssignToConstructorPromotionRector suggestion.
Clarify that the failure is silent for the user, but logged at debug level for diagnostics.
Co-authored-by: Bob van de Vijver <bobvandevijver@users.noreply.github.com>
This reverts commit c4df383.
bobvandevijver
force-pushed
the
fix/timed-publish-subscriber-dbal4
branch
from
July 20, 2026 14:15
ba60a56 to
a85b839
Compare
bobvandevijver
enabled auto-merge (squash)
July 20, 2026 14:18
bobvandevijver
disabled auto-merge
July 20, 2026 14:19
Member
|
Thank you @Senne! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3748